banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Hi Ruchir,

thanks for your response. It seems to me that changing an account is as easy as changing any m2o in an editable tree. But as this functionality sits in an option module it's alright with me.

I get the journal_id, it is a hack in the standard OpenERP search() method for account.account.

As for the bug report, the button is now only visible for draft lines, which is half of the solution. You also need to make it invisible on lines that have a match type. Note that 'attrs' and 'state' attributes don't combine well if I remember correctly, but you can replace the state attribute by an attrs on two conditions in the 'invisible' domain.

Nits:
You should put an author in __openerp__.py. Category should be 'Banking addons' or 'Usability'. You could improve the description by stating that you make it easier to change the account by adding a wizard to change the account in a popup.

ll.81,250: specifying the view type is deprecated in OpenERP 7.0
l.193: osv.osv_memory is deprecated in OpenERP 7.0, please use orm.TransientModel
l.217: acc_st_pool is not used, you can remove the line
ll.213, 214: I find account_pool misleading. Could you make this st_line_pool or something similar?
l. 234: odd indentation, need space after comma
l. 237 No need to instantiate the model from OpenERP 6.1 on. You can remove the line and the newline above.




-- 
https://code.launchpad.net/~ruchir.shukla/banking-addons/banking-addons-change-account_bank_transaction_line/+merge/202409
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.