← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-70-pos_compat-afe into lp:banking-addons/bank-statement-reconcile-7.0

 

Review: Approve code review, no tests

Nicolas should we wait for the hook or can we proceed with this monkey patching?


Alexandre, Nicolas did we ask odony already for a hook in pos_session.create

IMHO as long the MP in addons(1) is not merged we can apply the fix and remove it later 

(1)https://code.launchpad.net/~camptocamp/openobject-addons/7.0-fix-1245375-afe/+merge/192848
https://code.launchpad.net/~camptocamp/openobject-addons/trunk-fix-1245375-afe/+merge/192849

Otherwise LGTM
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-pos_compat-afe/+merge/193807
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.


References