banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~akretion-team/banking-addons/bank-statement-reconcile-7.0-add-completion-label into lp:banking-addons/bank-statement-reconcile-7.0

To: Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Fri, 31 Jan 2014 10:41:35 -0000
In-reply-to: <20131204172505.32517.22592.launchpad@ackee.canonical.com>
Reply-to: mp+197758@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

261-274 This double loop seems inefficient, with thousands of labels, it will loop over each of them and do an additional query even if the label has nothing to do with the statement. You should rather loop on the statement lines to complete and query the labels in the inner loop.

Thanks for your proposal
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-7.0-add-completion-label/+merge/197758
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.