banking-addons-team team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

Hmm not sure if your fix is really ok, though:

regexp_matches(string text, pattern text [, flags text])

it seems to me that you have either inverted the args to that function, or you end up using re.escape on the wrong parameter. 

Automated test definitely needed. 
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/7.0-bug-1280814-base_completion/+merge/206617
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.