banking-addons-team team mailing list archive

["Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>]

> my understanding of regexp_matches is that arg 1 is the string we want to
> check, and arg 2 is the regular expression against which we to the matching
> (http://www.postgresql.org/docs/9.1/static/functions-matching.html)
> 
> In the code you propose to merge, you pass a regular expression ('.*' +
> re.escape(str) + '.*') as the first argument, and a string from the db (which
> may contain unescaped regular expression special characters such as .) as the
> regexp value. So this needs to be fixed : at the very least the convertsion of
> st_line['name'] to a regexp should be removed. And I'm interested in a test in
> which a partner has name "jh..doe" and a statement line has value 'jheudoe'.

Hi Alexandre,

The code has been modified according to your review.

lmi
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/7.0-bug-1280814-base_completion/+merge/206617
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.