banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~pedro.baeza/banking-addons/bank-statement-reconcile-70-import_imp into lp:banking-addons/bank-statement-reconcile-7.0

To: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
From: Christophe Combelles <ccomb@xxxxxxx>
Date: Mon, 24 Feb 2014 23:26:38 -0000
In-reply-to: <20131224182224.26676.65181.launchpad@ackee.canonical.com>
Reply-to: mp+200022@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I've tried with only one filter module, and it allows to have it appear in the list.
Didn't have time to try with 2 filter modules though.
Renaming the selection field function is clever as it avoid to change all the filter modules around.
However there is no added unit test :'( This should be proposed in another MP maybe.
-- 
https://code.launchpad.net/~pedro.baeza/banking-addons/bank-statement-reconcile-70-import_imp/+merge/200022
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

lp:~pedro.baeza/banking-addons/bank-statement-reconcile-70-import_imp into lp:banking-addons/bank-statement-reconcile-7.0
From: Pedro Manuel Baeza, 2013-12-24