banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Hi Ruchir,

thank you for your changes. Only comment is:

- l.87: as with your other proposal, it seems to me that the button should be invisible if there is any match type at all.

You specified two match types here, but I think you should specify when there is any match type at all, like in your general fix for the issue.


-- 
https://code.launchpad.net/~ruchir.shukla/banking-addons/banking-addons-change-account_bank_transaction_line/+merge/202409
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.