banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-related-balance-check into lp:banking-addons/bank-statement-reconcile-7.0

To: Leonardo Pistone - camptocamp <leonardo.pistone@xxxxxxxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Fri, 07 Mar 2014 16:33:30 -0000
In-reply-to: <20140306163822.1034.42800.launchpad@ackee.canonical.com>
Reply-to: mp+209723@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review

I prefer to use self.pool['account.statement.profile'] in trigger methods even if self is already the instance of 'account.statement.profile' just for clarity and explicitness. But this is correct too, so LGTM.
Thanks
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-related-balance-check/+merge/209723
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

[Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-related-balance-check into lp:banking-addons/bank-statement-reconcile-7.0
From: Leonardo Pistone - camptocamp, 2014-03-06