banking-addons-team team mailing list archive
-
banking-addons-team team
-
Mailing list archive
-
Message #01691
Re: [Merge] lp:~therp-nl/banking-addons/ba70-deprecate_iban_lookup into lp:banking-addons
Review: Needs Fixing code review
You should remove unused import from account_banking.
account_banking/account_banking.py|68 col 1| F401 'SUPERUSER_ID' imported but unused
account_banking/account_banking.py|70 col 1| F401 'sepa' imported but unused
account_banking/account_banking.py|71 col 1| F401 'get_or_create_bank' imported but unused
Plus I had a conflict on account_banking.py on removals of res_partner_bank and res_bank classes. Can you check that and if needed merge main branch in here to solve it.
--
https://code.launchpad.net/~therp-nl/banking-addons/ba70-deprecate_iban_lookup/+merge/202520
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.
References