banking-addons-team team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review

Please replace old naming of exception to new one on l.20:

raise orm.except_orm

I think you can also simplify xpath expression to make it more portable to future versions, using relative xpaths (I'm not sure if the expression is 100% correct, because I have made it from memory, but it's worth while to explore this option):

<xpath expr="//field[@name='line_ids']/form//field[@name='account_id']" position="attributes">

Regards.
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-account-not-mandatory/+merge/197755
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.