← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~akretion-team/banking-addons/70-communication-communication2-clarify into lp:banking-addons

 

Review: Needs Fixing

See my comments on the mailing list. You should revise the assignment of communication{,2} in the override of payment.order.create and migrate current databases and handling of these fields. Please put the refactoring of _prepare_method in a later merge so that we can easily track the changes to this method.

Thanks!
-- 
https://code.launchpad.net/~akretion-team/banking-addons/70-communication-communication2-clarify/+merge/212271
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.


References