banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/ba70-camt_ignore_empty_statements into lp:banking-addons.

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/ba70-camt_ignore_empty_statements/+merge/212843

Ignore empty statements in CAMT.053 parser. Empty statements are harmful because they don't have a statement date yet and cause problems later on.
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba70-camt_ignore_empty_statements/+merge/212843
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~therp-nl/banking-addons/ba70-camt_ignore_empty_statements into lp:banking-addons.

=== modified file 'account_banking_camt/camt.py'
--- account_banking_camt/camt.py	2014-03-20 11:03:58 +0000
+++ account_banking_camt/camt.py	2014-03-26 13:23:01 +0000
@@ -274,5 +274,7 @@
         self.assert_tag(root[0][0], 'GrpHdr')
         statements = []
         for node in root[0][1:]:
-            statements.append(self.parse_Stmt(cr, node))
+            statement = self.parse_Stmt(cr, node)
+            if len(statement.transactions):
+                statements.append(statement)
         return statements