← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-account_easy_reconcile-analytic-account into lp:banking-addons/bank-statement-reconcile-7.0

 

Review: Needs Fixing code review

Please put False default to avoid extrange values (browse_null or similar) on dictionary on l.32:

'analytic_account_id': (rec_method.analytic_account_id and
                        rec_method.analytic_account_id.id or False),

Regards.
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-account_easy_reconcile-analytic-account/+merge/213007
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.


Follow ups

References