← Back to team overview

banking-addons-team team mailing list archive

[Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre into lp:banking-addons/bank-statement-reconcile-7.0

 

Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre into lp:banking-addons/bank-statement-reconcile-7.0.

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)
Related bugs:
  Bug #1301781 in Banking Addons: "Account voucher killer"
  https://bugs.launchpad.net/banking-addons/+bug/1301781

For more details, see:
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre/+merge/213975

It take the date of the payment line to set the bank statement line instead of maturity date of the payment line
See bug report
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre/+merge/213975
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre into lp:banking-addons/bank-statement-reconcile-7.0.
=== modified file 'statement_voucher_killer/voucher.py'
--- statement_voucher_killer/voucher.py	2013-08-27 06:20:04 +0000
+++ statement_voucher_killer/voucher.py	2014-04-03 07:58:56 +0000
@@ -81,7 +81,7 @@
                 'statement_id': statement_id,
                 'ref': line.ref,
                 'voucher_id': False,
-                'date': time.strftime('%Y-%m-%d'),
+                'date': line_date,
             }, context=context)
         return {'type': 'ir.actions.act_window_close'}
 
@@ -108,7 +108,7 @@
 
         for line in line_obj.browse(cr, uid, line_ids, context=context):
             ctx = context.copy()
-            ctx['date'] = line.ml_maturity_date  # Last value_date earlier,but this field exists no more now
+            ctx['date'] = line.date or statement.date  # Last value_date earlier,but this field exists no more now
             amount = currency_obj.compute(cr, uid, line.currency.id,
                     statement.currency.id, line.amount_currency, context=ctx)
             if not line.move_line_id.id:
@@ -122,7 +122,7 @@
                 'account_id': line.move_line_id.account_id.id,
                 'statement_id': statement.id,
                 'ref': line.communication,
-                'date': line.date or line.ml_maturity_date or statement.date,
+                'date': ctx['date'],
                 }, context=context)
 
             line_obj.write(cr, uid, [line.id], {'bank_statement_line_id': st_line_id})


Follow ups