banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/banking-addons/7.0-bank-statement-reconcile-account_invoice_reference into lp:banking-addons/bank-statement-reconcile-7.0

To: mp+212099@xxxxxxxxxxxxxxxxxx
From: Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>
Date: Mon, 07 Apr 2014 09:16:48 -0000
In-reply-to: <20140321075532.23549.44711.launchpad@ackee.canonical.com>
Reply-to: mp+212099@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Really good work and really interesting module Guewen!!
It's a huge pain to never know what is ref what is name...

Just on thing you redifine the fonction "def action_number", don't you think it will be better to change it with monkey patching?
Indeed if a module overwrite this function and call super, the module can be broken due to the redefinition.

By the way thank for this great module !
-- 
https://code.launchpad.net/~camptocamp/banking-addons/7.0-bank-statement-reconcile-account_invoice_reference/+merge/212099
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

[Merge] lp:~camptocamp/banking-addons/7.0-bank-statement-reconcile-account_invoice_reference into lp:banking-addons/bank-statement-reconcile-7.0
From: Guewen Baconnier @ Camptocamp, 2014-03-21