← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~akretion-team/banking-addons/70-fully-handle-payment-types into lp:banking-addons

 

Hello,

I believed that this fat do_merge method would have been refactored in trunk or trunk-wms. Sadly I just checked and I had wrong expectation: it stayed nearly the same. Eventually, if a simple patch is envisioned to make do_merge easier to override we may consider refactoring it very lightly in OCB and having a hook working here. Now, may be we should just first merge Alexis's improvement and leave this minor detail for later?


for reference:
7.0: https://github.com/akretion/openerp-addons/blob/ocb-7.0/purchase/purchase.py#L751
trunk: https://github.com/akretion/openerp-addons/blob/master/purchase/purchase.py#L749
trunk-wms: https://github.com/akretion/openerp-addons/blob/trunk-wms/purchase/purchase.py#L829
-- 
https://code.launchpad.net/~akretion-team/banking-addons/70-fully-handle-payment-types/+merge/211283
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.


References