banking-addons-team team mailing list archive

[Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>]

Review: Needs Information code review

Hello,

First of all, apologies for commenting so late in the review process.

We are also looking at solutions to support multiple statements in the same file, in order to support belgian CODA files.

I have looked at your merge proposal and the cfonb parser and I'm actually a bit uneasy with the proposed mechanism which requires storing parser state in the context between calls to parse().

Would you consider a variant where the parser is created (new_bank_statement_parser) in multi_statement_import, and then having statement_import called repeatedly with the same parser instance until parser.parse returns no data?

Best regards,
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-multi-statements/+merge/209863
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.