← Back to team overview

banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi into lp:banking-addons/bank-statement-reconcile-7.0

To: "Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Mon, 05 May 2014 13:53:31 -0000
In-reply-to: <20140428151821.13132.28283.launchpad@ackee.canonical.com>
Reply-to: mp+217467@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

LGTM

Thanks for the tests

As a side note for the next time you could use setUp() instead of calling each time prepare.
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi/+merge/217467
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

Follow ups

Re: [Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi into lp:banking-addons/bank-statement-reconcile-7.0
From: Laurent Mignon (Acsone), 2014-05-05

References

[Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi into lp:banking-addons/bank-statement-reconcile-7.0
From: Laurent Mignon (Acsone), 2014-04-28