banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-multi-statements into lp:banking-addons/bank-statement-reconcile-7.0

To: "Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Fri, 16 May 2014 14:47:42 -0000
In-reply-to: <20140515113054.18983.11820.launchpad@ackee.canonical.com>
Reply-to: mp+219683@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

l.57 and l.64 comment mismatch with prof parametre. prof or profile ?


A docstring on multi_statement_import would be a good idea as all method have one in that file let's keep it documented.


l.44 you can use self.pool[''] instead of self.pool.get('')
l.47 + l.53 > 80 characters
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-multi-statements/+merge/219683
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

[Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-multi-statements into lp:banking-addons/bank-statement-reconcile-7.0
From: Laurent Mignon (Acsone), 2014-05-15