← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-account_easy_reconcile-analytic-account into lp:banking-addons/bank-statement-reconcile-7.0

 

Review: Approve code review, no test

Hello Pedro, I don't see either how it could return browse_null.

IMO, we could even simply write

'analytic_account_id': rec_method.analytic_account_id.id,

As if rec_method.analytic_account_id is browse_null
rec_method.analytic_account_id.id would return False

But LGTM like this.
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-account_easy_reconcile-analytic-account/+merge/213007
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.


References