bigdata-dev team mailing list archive

[Cory Johns <cory.johns@xxxxxxxxxxxxx>]

Cory Johns has proposed merging lp:~bigdata-dev/charms/trusty/apache-pig/trunk into lp:charms/trusty/apache-pig.

Requested reviews:
  charmers (charmers)

For more details, see:
https://code.launchpad.net/~bigdata-dev/charms/trusty/apache-pig/trunk/+merge/273431

Remove trivial test in favor of bundle tests.
-- 
Your team Juju Big Data Development is subscribed to branch lp:~bigdata-dev/charms/trusty/apache-pig/trunk.

=== removed directory 'tests'
=== removed file 'tests/00-setup'
--- tests/00-setup	2015-09-16 21:40:36 +0000
+++ tests/00-setup	1970-01-01 00:00:00 +0000
@@ -1,8 +0,0 @@
-#!/bin/bash
-
-if ! dpkg -s amulet &> /dev/null; then
-    echo Installing Amulet...
-    sudo add-apt-repository -y ppa:juju/stable
-    sudo apt-get update
-    sudo apt-get -y install amulet
-fi

=== removed file 'tests/100-deploy-pig'
--- tests/100-deploy-pig	2015-09-16 21:46:32 +0000
+++ tests/100-deploy-pig	1970-01-01 00:00:00 +0000
@@ -1,86 +0,0 @@
-#!/usr/bin/env python3
-import unittest
-import amulet
-
-
-class TestDeploy(unittest.TestCase):
-    """
-    Deployment test for Apache Pig using HDFS as shared storage and YARN as
-    cluster job manager.
-    """
-
-    @classmethod
-    def setUpClass(cls):
-        cls.d = amulet.Deployment(series='trusty')
-        # Deploy a hadoop cluster
-        cls.d.add('yarn-master', charm='cs:trusty/apache-hadoop-yarn-master')
-        cls.d.add('hdfs-master', charm='cs:trusty/apache-hadoop-hdfs-master')
-        cls.d.add('compute-slave', charm='cs:trusty/apache-hadoop-compute-slave', units=3)
-        cls.d.add('plugin', charm='cs:trusty/apache-hadoop-plugin')
-        cls.d.relate('yarn-master:namenode', 'hdfs-master:namenode')
-        cls.d.relate('compute-slave:nodemanager', 'yarn-master:nodemanager')
-        cls.d.relate('compute-slave:datanode', 'hdfs-master:datanode')
-        cls.d.relate('plugin:resourcemanager', 'yarn-master:resourcemanager')
-        cls.d.relate('plugin:namenode', 'hdfs-master:namenode')
-
-        # Add Pig Service
-        cls.d.add('pig', charm='cs:trusty/apache-pig')
-        cls.d.relate('pig:hadoop-plugin', 'plugin:hadoop-plugin')
-
-        cls.d.setup(timeout=3600)
-        cls.d.sentry.wait(timeout=3600)
-        cls.unit = cls.d.sentry.unit['pig/0']
-
-
-###########################################################################
-# Validate yarn mapreduce operation from the Pig node
-# 1) validate mapreduce execution - writing to hdfs
-###########################################################################
-    def test_yarn_mapreduce_exe1(self):
-        outdir = "/user/ubuntu/teragenout"
-        o, c = self.unit.run("su ubuntu -c 'hdfs dfs -rm -f -R %s &&"
-                             "hadoop jar /usr/lib/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-examples*.jar teragen 10000 %s'"
-                             % (outdir, outdir))
-        assert c == 0, "Teragen failed to execute: %s" % o
-
-###########################################################################
-# 2) validate successful mapreduce operation after the execution
-###########################################################################
-        o, c = self.unit.run("su hdfs -c 'hdfs dfs -ls %s/_SUCCESS'" % outdir)
-        assert c == 0, "Teragen executed, but expected output was not found: %s" % o
-
-###########################################################################
-# Validate mapreduce operation from Pig node - validates job chain operation
-# 1) validate mapreduce execution - reading and writing to hdfs
-###########################################################################
-    def test_yarn_mapreduce_exe2(self):
-        indir = "/user/ubuntu/teragenout"
-        outdir = "/user/ubuntu/terasortout"
-        o, c = self.unit.run("su ubuntu -c 'hdfs dfs -rm -f -R %s &&"
-                             "hadoop jar /usr/lib/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-examples*.jar terasort %s %s'"
-                             % (outdir, indir, outdir))
-        assert c == 0, "Terasort failed to execute: %s" % o
-
-###########################################################################
-# 2) validate a successful mapreduce operation after the execution
-###########################################################################
-        o, c = self.unit.run("su hdfs -c 'hdfs dfs -ls %s/_SUCCESS'" % outdir)
-        assert c == 0, "Terasort executed, but expected output was not found: %s" % o
-
-###########################################################################
-# Validate Pig can start in local mode
-###########################################################################
-    def test_pig_local(self):
-        o, c = self.unit.run("su ubuntu -c 'pig -i -x local'")
-        assert "Apache" in o, "Pig local mode failed: %s" % o
-
-###########################################################################
-# Validate Pig can start in mapred mode
-###########################################################################
-    def test_pig_mapred(self):
-        o, c = self.unit.run("su ubuntu -c 'pig -i'")
-        assert "Apache" in o, "Pig MapReduce mode failed: %s" % o
-
-
-if __name__ == '__main__':
-    unittest.main()

=== removed directory 'tests/remote'
=== removed file 'tests/remote/test_dist_config.py'
--- tests/remote/test_dist_config.py	2015-08-21 21:51:57 +0000
+++ tests/remote/test_dist_config.py	1970-01-01 00:00:00 +0000
@@ -1,71 +0,0 @@
-#!/usr/bin/env python
-
-import grp
-import os
-import pwd
-import unittest
-
-import jujubigdata
-
-
-class TestDistConfig(unittest.TestCase):
-    """
-    Test that the ``dist.yaml`` settings were applied properly, such as users, groups, and dirs.
-
-    This is done as a remote test on the deployed unit rather than a regular
-    test under ``tests/`` because filling in the ``dist.yaml`` requires Juju
-    context (e.g., config).
-    """
-    @classmethod
-    def setUpClass(cls):
-        config = None
-        config_dir = os.environ['JUJU_CHARM_DIR']
-        config_file = 'dist.yaml'
-        if os.path.isfile(os.path.join(config_dir, config_file)):
-            config = os.path.join(config_dir, config_file)
-        if not config:
-            raise IOError('Could not find {} in {}'.format(config_file, config_dir))
-        reqs = ['vendor', 'hadoop_version', 'groups', 'users', 'dirs']
-        cls.dist_config = jujubigdata.utils.DistConfig(config, reqs)
-
-    def test_groups(self):
-        for name in self.dist_config.groups:
-            try:
-                grp.getgrnam(name)
-            except KeyError:
-                self.fail('Group {} is missing'.format(name))
-
-    def test_users(self):
-        for username, details in self.dist_config.users.items():
-            try:
-                user = pwd.getpwnam(username)
-            except KeyError:
-                self.fail('User {} is missing'.format(username))
-            for groupname in details['groups']:
-                try:
-                    group = grp.getgrnam(groupname)
-                except KeyError:
-                    self.fail('Group {} referenced by user {} does not exist'.format(
-                        groupname, username))
-                if group.gr_gid != user.pw_gid:
-                    self.assertIn(username, group.gr_mem, 'User {} not in group {}'.format(
-                        username, groupname))
-
-    def test_dirs(self):
-        for name, details in self.dist_config.dirs.items():
-            dirpath = self.dist_config.path(name)
-            self.assertTrue(dirpath.isdir(), 'Dir {} is missing'.format(name))
-            stat = dirpath.stat()
-            owner = pwd.getpwuid(stat.st_uid).pw_name
-            group = grp.getgrgid(stat.st_gid).gr_name
-            perms = stat.st_mode & ~0o40000
-            self.assertEqual(owner, details.get('owner', 'root'),
-                             'Dir {} ({}) has wrong owner: {}'.format(name, dirpath, owner))
-            self.assertEqual(group, details.get('group', 'root'),
-                             'Dir {} ({}) has wrong group: {}'.format(name, dirpath, group))
-            self.assertEqual(perms, details.get('perms', 0o755),
-                             'Dir {} ({}) has wrong perms: 0o{:o}'.format(name, dirpath, perms))
-
-
-if __name__ == '__main__':
-    unittest.main()

=== removed file 'tests/tests.yaml'
--- tests/tests.yaml	2015-06-25 14:51:21 +0000
+++ tests/tests.yaml	1970-01-01 00:00:00 +0000
@@ -1,10 +0,0 @@
-# Driver for bundletester: https://github.com/juju-solutions/bundletester
-#
-# It may be useful to alter the defaults during manual testing. For example,
-# set 'reset: false' to reuse existing charms instead of redeploying them.
-
-# Allow bootstrap of current env, default: true
-bootstrap: true
-
-# Use juju-deployer to reset env between test, default: true
-reset: true