bigdata-dev team mailing list archive

[Felipe Reyes <felipe.reyes@xxxxxxxxxxxxx>]

Felipe Reyes has proposed merging lp:~freyes/charms/xenial/rsyslog/lp1694270 into lp:~bigdata-dev/charms/xenial/rsyslog/trunk.

Requested reviews:
  Juju Big Data Development (bigdata-dev)
Related bugs:
  Bug #1694270 in rsyslog (Juju Charms Collection): "rsyslog logrotate template invokes 'reload rsyslog' which fails in Xenial"
  https://bugs.launchpad.net/charms/+source/rsyslog/+bug/1694270

For more details, see:
https://code.launchpad.net/~freyes/charms/xenial/rsyslog/lp1694270/+merge/324743

Use 'rotate' action from /etc/init.d/rsyslog
  
'reload' command does not exist in Xenial, the rsyslog package uses the
'rotate' functionality implemented in the sysvinit script to close all
open file descriptors.

-- 
Your team Juju Big Data Development is requested to review the proposed merge of lp:~freyes/charms/xenial/rsyslog/lp1694270 into lp:~bigdata-dev/charms/xenial/rsyslog/trunk.

=== modified file 'templates/rsyslog.conf'
--- templates/rsyslog.conf	2014-04-22 19:45:41 +0000
+++ templates/rsyslog.conf	2017-05-29 14:02:29 +0000
@@ -1,3 +1,8 @@
+###############################################################################
+# [ WARNING ]
+# Configuration file maintained by Juju. Local changes may be overwritten.
+###############################################################################
+
 /var/log/syslog
 {
 	rotate {{syslog_rotate}}
@@ -7,7 +12,7 @@
 	delaycompress
 	compress
 	postrotate
-		reload rsyslog >/dev/null 2>&1 || true
+    invoke-rc.d rsyslog rotate > /dev/null
 	endscript
 }
 
@@ -32,6 +37,6 @@
 	delaycompress
 	sharedscripts
 	postrotate
-		reload rsyslog >/dev/null 2>&1 || true
+		invoke-rc.d rsyslog rotate > /dev/null
 	endscript
 }