bind-charmers team mailing list archive
-
bind-charmers team
-
Mailing list archive
-
Message #00024
[Merge] ~barryprice/charm-k8s-bind/+git/bind-k8s-image-builder:master into ~bind-charmers/charm-k8s-bind/+git/bind-k8s-image-builder:master
Barry Price has proposed merging ~barryprice/charm-k8s-bind/+git/bind-k8s-image-builder:master into ~bind-charmers/charm-k8s-bind/+git/bind-k8s-image-builder:master.
Commit message:
Fix logical operator precedence
Requested reviews:
Bind Charmers (bind-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-bind/+git/bind-k8s-image-builder/+merge/387938
--
Your team Bind Charmers is requested to review the proposed merge of ~barryprice/charm-k8s-bind/+git/bind-k8s-image-builder:master into ~bind-charmers/charm-k8s-bind/+git/bind-k8s-image-builder:master.
diff --git a/Makefile b/Makefile
index c270c46..4af4079 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@ DOCKER_DEPS = bind9 git
deps:
@echo "Checking shellcheck is present."
- @which shellcheck >/dev/null || echo "Please install shellcheck to continue ('sudo snap install shellcheck')" && false
+ @which shellcheck >/dev/null || { echo "Please install shellcheck to continue ('sudo snap install shellcheck')" && false; }
lint: deps
@echo "Running shellcheck."
Follow ups