birdie-team team mailing list archive

[Eder Sosa <eder.sohe@xxxxxxxxx>]

Eder Sosa has proposed merging lp:~edersohe/birdie/fix-1156043 into lp:birdie.

Requested reviews:
  Birdie Team (birdie-team)
Related bugs:
  Bug #1156043 in Birdie: "don't underline @names and #tags"
  https://bugs.launchpad.net/birdie/+bug/1156043

For more details, see:
https://code.launchpad.net/~edersohe/birdie/fix-1156043/+merge/153993
-- 
https://code.launchpad.net/~edersohe/birdie/fix-1156043/+merge/153993
Your team Birdie Team is requested to review the proposed merge of lp:~edersohe/birdie/fix-1156043 into lp:birdie.

=== modified file 'src/Twitter.vala'
--- src/Twitter.vala	2013-03-17 02:30:05 +0000
+++ src/Twitter.vala	2013-03-19 05:43:21 +0000
@@ -288,9 +288,9 @@
 
             try {
                 urls = new Regex("((http|https|ftp)://([\\S]+))");
-                text = urls.replace(text, -1, 0, "<a href='\\0'>\\0</a>");
+                text = urls.replace(text, -1, 0, "<span underline='none'><a href='\\0'>\\0</a></span>");
                 urls = new Regex("([@#][a-zA-Z0-9_]+)");
-                text = urls.replace(text, -1, 0, "<a href='https://twitter.com/\\0'>\\0</a>");
+                text = urls.replace(text, -1, 0, "<span underline='none'><a href='https://twitter.com/\\0'>\\0</a></span>");
             } catch (RegexError e) {
                 warning ("regex error: %s", e.message);
             }