boots-developers team mailing list archive

[Eric Day <eday@xxxxxxxxxxxx>]

Hi Ashish,

I took a thorough look at the work you did around tab completion and
also looked at the docs you've created, excellent job!

The tab completion works well for me, and as we talked the next step
is getting the query results from the INFORMAION_SCHEMA table into
the match possibilities. We can simply put a DB query command in
there when it needs to be populated, but I would like to hear from
the original Boots devs to see how they think we can best plug this
in, possibly reusing the query framework we already have in boots. We
could always just put in a simply libdrizzle or libmysql command for
now just to test it.

As for the docs, it looks like you did a thorough job documenting all
the modules and classes. The pep8 and pylint command line tools can
be helpful for finding anything you're missing (docs or code style
things), so it might be useful to run them on your changes just
to check things. The only thing that should probably change with
the docs is to not check in the generated HTML output. Generally,
you only want to check in original source/scripts/.. to the code
repository. Anything that can be automatically generated (like the
sphinx docs) you don't want to check in.

It's been great seeing all this work come together, you did a great
job completing most of you tasks. As is almost always the case, things
take longer than usual, so you can't always complete everything you
plan for (especially on a rigid timiline like GSOC).

Let me know if there is anything else I can help you with to wrap
things up. Again, great job!

-Eric

On Mon, Aug 09, 2010 at 10:42:36PM +0530, Ashish wrote:
> Hi,
>         Good Morning. I have created tab completion module and
> updated it in the old curses branch.
> I have written it to be flexible so that later on it is easy to add
> new sources of identifiers.
> 
> But I still need to find a way of fetching db names, table names etc
> from server.
> 
> This tab completion works with curses ui only. You may get it from
> https://code.launchpad.net/~ashishsharma/boots/curses-devel
> 
> Also, I'll put the docs in reStructuredText using sphinx in the
> other branch
> https://code.launchpad.net/~ashishsharma/boots/gsoc-docs  and host
> html form at http://web.iiit.ac.in/~ashishsharma/gsoc/docs .
> 
> Please use and review this work.
> 
> Regards,
> Ashish Sharma (_buck)