budgie-remix-bug-busters team mailing list archive

[Mattia Rizzolo <mattia@xxxxxxxxxxx>]

Well, it's the job of the packager to remove those "hangover".. :)

now,
1) what's with that new "dpkg-dev (>= 1.16.1.1)" build-dep?  why?
2) -dev packages should (must really…) not be named after the version of the lib; see debian policy 8.4
3) please read debhelper(7) about what compat 10 brings; --parallel in d/rules is unneeded now
4) why are you including /usr/share/dpkg/buildflags.mk and setting that env variable?  did you read about debhelper(7) comapt 9 that should already set all of those variables that you are explicitly asking to be exported?
5) you overrode that lintian tag binary-without-manpage with a comment that equals to "yes, this package builds a manpage"; that's not useful.  I don't believe that tag should be overrode, unless you have a good reason to; a missing manpage is actually a bug (policy 12.1)
6) I doubt this does any good:
-       docbook-to-man debian/vala-panel.1.sgml > debian/vala-panel.1
+       mkdir -p usr/share/man1
+       docbook-to-man debian/vala-panel-runner.1.sgml > usr/share/man1/vala-panel-runner.1
and indeed that file is installed nowhere.  The path is wrong (missing a /man/ in the middle), also you are creating a whole new tree that is used for nothing but installing that manpage; tbh I don't find it elegant.  I'd either run it after dh_auto_install and place it directly in debian/tmp/usr/share/man/man1/, or leave it as it was before in debian/. and ask dh_installman to install it.
7) I: vala-panel-plugins-wnck: description-synopsis-might-not-be-phrased-properly
8) I: vala-panel-plugins-base: description-synopsis-might-not-be-phrased-properly
9) I: vala-panel: description-synopsis-might-not-be-phrased-properly
10) I: vala-panel: extended-description-is-probably-too-short
11) please consider sending upstream fixes for desktop-entry-lacks-keywords-entry and spelling-error-in-manpage
12) in d/copyrigt, the name of Konstantin has a spurious '<' before
13) lib/guuid.{c,h} are under LGPL-2.1+, not LGPL-3+
14) applets/wnck/icontasks is under GPL-2+ not LGPL-3+ — btw, this is OK to do, but it makes the whole mix a GPL-3; I wonder whether upstream is aware...
15) applets/wnck/tasklist-xfce and applets/wnck/xembed: same as above


** Changed in: ubuntu
       Status: Confirmed => Incomplete

-- 
You received this bug notification because you are a member of ubuntu
budgie bug busters, which is subscribed to Ubuntu Budgie.
https://bugs.launchpad.net/bugs/1699333

Title:
  [needs-packaging] vala-panel

Status in Ubuntu Budgie:
  New
Status in Ubuntu:
  Incomplete

Bug description:
  Vala Panel is GTK+ 3 desktop panel based on ideas from LXPanel.

    * vala-panel

  URL: https://github.com/rilian-la-te/vala-panel
  License: LGPL-3.0
  Notes: I'm working upstream to maintain the packaging for vala-panel and will ask the DMB to allow vala-panel to be included in the the Ubuntu MATE package set so I can maintain it in the Ubuntu archive. vala-panel-appmenu has a dependency on vala-panel. vala-panel-appmenu has a needs-packaging bug too (LP: #1699334)

  [needs-packaging] vala-panel

  The source and documentation is available from the following
  repository:

    * https://github.com/rilian-la-te/vala-panel

  The packaging can be found here:

    * https://github.com/rilian-la-te/vala-project-packages

  A .dsc can be downloaded from ppa:flexiondotorg/needs-packaging using:

      dget -u -x https://launchpad.net/~flexiondotorg/+archive/ubuntu
  /needs-packaging/+files/vala-panel_0.3.65-0ubuntu1.dsc

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntubudgie/+bug/1699333/+subscriptions