budgie-remix-bug-busters team mailing list archive

[fossfreedom <2065708@xxxxxxxxxxxxxxxxxx>]

I presume that this is the apparmor SRU
https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/2064672

Can confirm that the apparmor changes for oracular work for BCC.  I've
uploaded to unstable a revert fix.

Lets close this SRU request once the apparmor changes have been
evaluated by the SRU team and if content test with them to check noble
works without needing this specific update.

** Changed in: budgie-control-center (Ubuntu Oracular)
       Status: Fix Released => In Progress

** Changed in: budgie-control-center (Ubuntu Oracular)
     Assignee: Sam Lane (samlane00) => fossfreedom (fossfreedom)

** Changed in: budgie-control-center (Ubuntu Oracular)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of ubuntu
budgie bug busters, which is subscribed to budgie-control-center in
Ubuntu.
https://bugs.launchpad.net/bugs/2065708

Title:
  Add Picture button in Background does not allow you to select
  wallpaper

Status in budgie-control-center package in Ubuntu:
  Fix Committed
Status in budgie-control-center source package in Noble:
  In Progress
Status in budgie-control-center source package in Oracular:
  Fix Committed

Bug description:
  [ Impact ]

   * On Ubuntu Budgie 24.04 / 24.10, When trying to select a custom
  wallpaper to add to the Backgrounds page of Budgie Control Center, the
  "Add Picture" button will open a dialog to select an image file.
  However, there will be no thumbnail of the image displayed in this
  dialog, the "Open" button will remain insensitive, and double-clicking
  the file name will have no effect. The only option is to cancel out of
  the dialog. This prevents the user from adding a custom wallpaper.
  This is due to AppArmor changes preventing certain apps doing deemed
  security related issues in userspace. In this case libgnome-desktop is
  calling bwrap which is the deemed culprit.

   * The upload addresses this issue by using GdkPixbuf to create the
  thumbnail image, instead of gnome-desktop thumbnail creator.

  [ Test Plan ]

   To reproduce:

   * On Ubuntu Budgie 24.04/24.10
   * Open Budgie Control Center
   * Navigate to the Background panel
   * Select the "Add Picture" option
   * Select an image file
   * The thumbnail is not updated to show the currently selected image
   * The "Open" button remains inactive, and the only option is to cancel the dialog

   * After this, the proposed fix can be applied.
   * Open Budgie Control Center and repeat the above
   * When a valid image is selected, the thumbnail is now properly shown and the "Open" button is enabled.
   * Open the selected image. The image is now properly added to Budgie Control Center and can selected as a background

  [ Where problems could occur ]

    * It is possible that gnome-desktop thumbnail creator provided additional functionality or handled a wider range of images than GdkPixbuf.
    * Mitigating factors are that this is very specific to the Budgie desktop, and it only directly impacts users who set wallpapers. It improves functionality where it is currently not working.

  [ Other Info ]

  --- Original Report ---

  Ubuntu Budgie 24.04
  budgie-control-center 1.4.0-2build3

  When trying to select a custom wallpaper to add to the Backgrounds
  page of Budgie Control Center, the "Add Picture" button will open a
  dialog to select an image file. However, there will be no thumbnail of
  the image displayed in this dialog, the "Open" button will remain
  insensitive, and double-clicking the file name will have no effect.
  The only option is to cancel out of the dialog.

  Steps to reproduce:

  On Ubuntu Budgie Noble / Oracular:
   - open Budgie Control Center
   - Navigate to the Backgrounds page and click the "Add Picture" button in the top right title bar.
   - When the file chooser dialog opens, select an image file.

  What I would expect to happen:

  I would expect the thumbnail to update in the lower right, and the
  "Open" button to become enabled.

  What happened instead:

  The "Open" button remains disabled, and the thumbnail is shown as a
  "?".

  Additional information:

  This is due to AppArmor changes preventing certain apps doing deemed security related issues in userspace.
  Running budgie-control-center from the terminal illustrates the issue with thumbnails with the following output:
  (budgie-control-center:38170): cc-background-chooser-WARNING **: 12:37:31.144: could not general thumbnail file:///home/sam/Pictures/flavors/Flavor-Ubuntu-Budgie.png (image/png) Child process exited with code 1

  ProblemType: Bug
  DistroRelease: Ubuntu 24.04
  Package: budgie-control-center 1.4.0-2build3
  ProcVersionSignature: Ubuntu 6.8.0-31.31-generic 6.8.1
  Uname: Linux 6.8.0-31-generic x86_64
  ApportVersion: 2.28.1-0ubuntu3
  Architecture: amd64
  CasperMD5CheckResult: pass
  CurrentDesktop: Budgie:GNOME
  Date: Tue May 14 12:38:19 2024
  InstallationDate: Installed on 2024-05-08 (6 days ago)
  InstallationMedia: Ubuntu-Budgie 24.04 LTS "Noble Numbat" - Release amd64 (20240424)
  SourcePackage: budgie-control-center
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/budgie-control-center/+bug/2065708/+subscriptions