bzr-explorer-dev team mailing list archive

[KOGA Mitsuhiro <shiena.jp@xxxxxxxxx>]

Ian, sorry.
I made a mistake in the check on the info character of the diagnosis mode dialog.
Please convert the args after displaying them in diagnostic mode. 
Because QMessageBox needs unicode.
And subprocess needs mbcs on windows.

-- 
Edit button does not work in non-ascii path name on Windows
https://bugs.launchpad.net/bugs/401579
You received this bug notification because you are a member of Bazaar
Explorer Developers, which is the registrant for Bazaar Explorer.

Status in Bazaar Explorer: Fix Released

Bug description:
platform: Windwos XP
bzr: 1.16.1
bzr-explorer: rev 177

I selected the non-ascii file and pushed the edit button.
However, the editor is not started. And I've got error:

Traceback (most recent call last):
  File "C:/Documents and Settings/username/Application Data/bazaar/2.0/plugins\explorer\lib\wt_browser.py", line 124, in do_edit_file
    self._action_callback("edit", unicode(path))
  File "C:/Documents and Settings/username/Application Data/bazaar/2.0/plugins\explorer\lib\explorer.py", line 903, in _do_view_action
    self.edit_file(target)
  File "C:/Documents and Settings/username/Application Data/bazaar/2.0/plugins\explorer\lib\explorer.py", line 845, in edit_file
    self.run_app(self._editor.split() + [path])
  File "C:/Documents and Settings/username/Application Data/bazaar/2.0/plugins\explorer\lib\explorer.py", line 794, in run_app
    subprocess.Popen(args)
  File "subprocess.pyo", line 594, in __init__
  File "subprocess.pyo", line 822, in _execute_child
UnicodeEncodeError: 'ascii' codec can't encode characters in position 40-42: ordinal not in range(128)


Fortunately, I found the same bug as bzr.
see:
https://bugs.launchpad.net/bzr/+bug/382709

I tried the same correction, and the editor came to start.