← Back to team overview

bzr-windows team mailing list archive

Re: Getting ready for bzr-2.0.0-1-setup.exe

 

John

Thanks for your interest in this. I think INPUTRC was a distraction.
On investigation I do have the envt variable INPUTRC set - it's to do
with European keyboard handling for the Ruby programming/scripting
language, and it has been there for over 3 years.

However, deleting this env var (and rebooting to convince Windoze that
I *really* don't want it any more...) has NO effect on the bzrtools
problem reported here.

I've tried your patch on the installed version of my bzrtools plugin.
[With INPUTRC still unset.]

It is effective in getting rid of the gross error I bugged, but throws
up a new run-time warning -

C:\Documents and Settings\David>bzr shell
bzr> versC:/Added Program Files/Bazaar/plugins\bzrtools\shell.py:284: Deprecatio
nWarning: bzrlib.commands.get_all_cmds was deprecated in version 1.17.0.

version-info  version
bzr> version

But the good news is that tab-complete does actually work as expected.

I'll re-instate my INPUTRC envt var and report back again.

Thanks

DJ

2009/9/22 John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> DeeJay wrote:
>> It's not a show stopper, and it's not a Windows-installer issue, but
>> to give Windows users the best possible experience of Bazaar 2.0.0 can
>> I point out Bug #431241 relating to shell (from bzrtools)
>> tab-completion fails on Windows but not on Linux.
>>
>> DJ
>>
>
> So the bug shows that readline is available, but it is somehow getting a
> '0xa0' in the config.
>
> Do you have a custom INPUTRC setup? Something that would have your own
> set of definitions about what keys get bound to what actions?
>
> I don't really know what the 0xa0 character is, though obviously it
> isn't an ASCII character (>127).
>
> Then again, maybe it is the list of lines that could be completed.
>
> The line that is failing is:
> if buf[self.begidx] in self.completer_delims:
>
> "in position 6" makes me think that it is something wrong with
> 'completer_delims" as I think "buf[self.begidx]" is going to be a single
> character.
>
> There are some abstractions that make it a little tricky to figure out
> what is going on.
>
> John
> =:->
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Cygwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkq5D2cACgkQJdeBCYSNAAPZ8gCgxI+e0Ao3+vStsfKvODMzYHD5
> bNoAn2Eozcm5Bfwm0wau3wI/GTpov6G9
> =cpBk
> -----END PGP SIGNATURE-----
>



References