bzr-windows team mailing list archive

[Nicholas Allen <nick.allen@xxxxxxxxxxxxx>]

Hi John,

Thanks for the suggestion but a few things are not clear to me due to
the lack of type information in the code. Must the config object passed
in be a bzrlib.config.Config object? I don't want to read or write any
settings in a branch's config files as they may be read only to the
email notifier. Also I want one config file that can be used for all
branches so that if a new branch is created under the directory being
monitored no new config settings need to be set for it.

If I'm not mistaken then the bzlib.smtp_connection needs a branch config
file and can't work with my master config file (that has nothing to do
with a branch). Is that correct? If so then I would like to just copy
the fix into the existing code.

Thanks,

Nick

John Arbash Meinel wrote:
>
> ...
>
> > I do not know why our mailserver does not support TLS.  It probably
> > should, but I do not administer it.  So I have to live with it.
>
> > I speculate from some posts that this TLS problem may not be present in
> > earlier versions of python's smtp.py, but I'd really liek to keep using
> > python 2.6.2 on my windows boxes.  So any suggestions on how to work
> > around it but keep using python *and* keeping our mailserver setup would
> > be most welcome.
>
> > ~M
>
>
> python 2.6 changes the semantics of the "starttls()" call. In 2.5 if
> there was a failure, it just returned an error code. In 2.6 it started
> raising an exception.
>
> The proper fix is actually included in bzrlib.smtp_connection. Where it
> checks to see if STARTTLS is supported before it tries to use it.
>
> The 'bzr-email' plugin was eventually updated with that fix, but my
> guess is that bzr-email-notifier copied the code from 'bzr-email' and
> did not fix it.
>
> My personal recommendation is to remove any smtp_connection code from
> bzr-email-notifier and just 'from bzrlib import smtp_connection' since
> that is generally going to be the most maintained version.
>
> John
> =:->