← Back to team overview

bzr-windows team mailing list archive

Re: Updated dependencies for building the Windows installer?


>>>>> "jam" == John Arbash Meinel <john@xxxxxxxxxxxxxxxxx> writes:

    jam> Ian Clatworthy wrote:
    >> I'm in the process of trying to build a Windows installer for bzr 2.2 on
    >> Python 2.6 and I'd like ot make sure I have all the pieces I need.
    >> http://wiki.bazaar.canonical.com/BzrWin32Installer lists quite a few, in
    >> particular:
    >> * PyCurl
    >> * Paramiko
    >> * PyCrypto
    >> * zlib
    >> Are all of these still needed? If so, I'm wondering if I ought to
    >> explicitly check they are installed during the installer build process
    >> (and give the user a nice message if they are not).
    >> Comments?
    >> Ian C.

    jam> I guess I should mention... we don't need pycurl and I
    jam> personally haven't used it for a long time. However, it means
    jam> that SSL certificates are not validated (urllib doesn't check
    jam> that the domain on the site matches the domain in the
    jam> certificate). The main tradeoff is interactivity, etc. PyCurl
    jam> runs in a C func, which means you can't interrupt long
    jam> downloads with ^C, etc.

There has been at least one person (sorry I don't remember the nick)
asking for https certificate validation on IRC (in the last two?
weeks). He was willing to create its own installer or at least being
able to build one on windows.

bzrlib.transport currently defaults to urllib for http and pycurl for

So packaging pycurl on windows will make it the default for https only.

The long term plan is still to implement certificate validation in

Finally, there are a couple of minor (YMMV) features available in pycurl
but not in urllib like support for NTLM on windows.