bzr-windows team mailing list archive

[Gary van der Merwe <garyvdm@xxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/08/2010 10:48, Alexander Belchenko wrote:
> Hi Gary,
> 
> Gary van der Merwe пишет:
>> I've reworked Naoki's patch some what. Rather than having a copy of bzr
>> for bzrw (which I believe will be irritating to maintain), I've created
>> a custom py2exe boot_common.py file, which is where the stderr is
>> changed by py2exe for windows_exe.
>>
>> Code:
>> lp:~garyvdm/bzr/bzrw
>> lp:~garyvdm/bzr-windows-installers/bzrw
> 
> I've looked at your code. It seems fine for me.
> Just one note about lp:~garyvdm/bzr/bzrw: please move boot_common.py
> file to tools/win32 subdirectory. Otherwise bb:approve.
> 

Thanks for the review. I'll do the boot_common.py move, and do a test
build, before merging.

Gary
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxWcFwACgkQd/3EdwGKOh2plQCcDkxpFPp1IHgaupkxezs7v/pa
V9cAn0yfoDXsDOr/p0Bj/PCmeGnSYJpL
=atmU
-----END PGP SIGNATURE-----