c2c-oerpscenario team mailing list archive

[xrg <xrg@xxxxxxxxx>]

On Monday 25 October 2010, you wrote:
> Public bug reported:
> 
> The hr addon reads a file named "photo.png" from "addons_path"
> configuration setting. But this setting can have multiple paths,
> separated by a comma. In this case, the function "_get_photo" crashes
> the server.
> 
> /addons/hr/hr.py
> 
> Line 186:
> + - return open(os.path.join(
> + -     tools.config['addons_path'], 'hr/image', 'photo.png'),
> + -         'rb') .read().encode('base64')
> + + paths = tools.config['addons_path'].split(',')
> + + for path in paths:
> + +     filename = os.path.join(path, 'hr/image', 'photo.png')
> + +     if os.path.isfile(filename):
> + +         return open(filename, 'rb').read().encode('base64')
> + + return None
> +

This code is not optimal, either. 
There is a "get_module_resource()" that you should use. Never access 
config['addons_path'] directly.

-- 
[trunk] hr and photo.png
https://bugs.launchpad.net/bugs/666475
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: New

Bug description:
The hr addon reads a file named "photo.png" from "addons_path" configuration setting. But this setting can have multiple paths, separated by a comma. In this case, the function "_get_photo" crashes the server.

/addons/hr/hr.py

Line 186:

- return open(os.path.join(
-     tools.config['addons_path'], 'hr/image', 'photo.png'),
-         'rb') .read().encode('base64')
+ paths = tools.config['addons_path'].split(',')
+ for path in paths:
+     filename = os.path.join(path, 'hr/image', 'photo.png')
+     if os.path.isfile(filename):
+         return open(filename, 'rb').read().encode('base64')
+ return None

NOTE: I have a problem with spaces in the editor