← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 522192] Re: Incorrect amount_to_text_en.py

 

** Changed in: openobject-server
       Status: New => Confirmed

** Changed in: openobject-server
   Importance: Undecided => Wishlist

-- 
Incorrect amount_to_text_en.py 
https://bugs.launchpad.net/bugs/522192
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Server: Confirmed

Bug description:
amount_to_text_en.py incorrect in structure. It shouldn't redefine so called "generic" functions and variables from amount_to_text.py, but should extend it in proper way - by using add_amount_to_text_function function.
To avoid confusion i propose to leave in amount_to_text.py "generic" functions only, and all localisation staff turn into amount_to_text_fr.py and so on.
Modules shouldn't direct use any "amount_to_text_XX" function, instead it should call generic amount_to_text.

Here is incorrect use from /account_voucher/report/report_voucher.py :

38 		    def convert(self,amount, cur):
39 		        amt_en = amount_to_text_en.amount_to_text(amount,'en',cur);
40 		        return amt_en