c2c-oerpscenario team mailing list archive

["rpa \(Open ERP\)" <666781@xxxxxxxxxxxxxxxxxx>]

Hello Lionel,
Thanks for your suggestions,
its improved in lp:~openerp-dev/openobject-addons/rpa-dev-addons2 by:
revision-id: rpa@xxxxxxxxxxx-20101104121148-g4cqx1bocnmxsued
revision-no: 4501
will be available in trunk soon...

** Changed in: openobject-addons
       Status: In Progress => Fix Released

-- 
useless list comprehension and browse in split_moves
https://bugs.launchpad.net/bugs/666781
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: Fix Released

Bug description:
Nothing important, but stock/stock_split_move.py has a portion that read like this:
        move_ids = [m.id for m in [line for line in pick.move_lines]]
        for move in move_obj.browse(cr, uid, move_ids, context=context):

I think [line for line in X] just makes a copy of X. Then we do it just to get ids and browse again.
So I suppose it should just read:
        for move in move_lines:
Lionel