c2c-oerpscenario team mailing list archive

[Joël Grand-Guillaume @ CampToCamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Hi Jay,


First thank you for your review ! I tested the patch and it doesn't seems to work for me:

- Making an SO with 1 product, confirm order, cancel shipping => the
"shipped" checkbox is ticked and the invoice generated when "Invoice on
Order After Delivery"

- Making an SO with 2 product, confirm order, accept one product and
cancel the second one => the "shipped" product is ticked

With the last patch, both were working as "shipped" was not ticked.

What's your opinion ?

Regards,

Joël

-- 
[5.0][sale] Cancelling an out picking sets the sale order as shipped
https://bugs.launchpad.net/bugs/646224
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: In Progress

Bug description:
Hi,

If I cancel an out picking, it always writes in sale order "shipped=True", because action_cancel() from stock.picking extended in sale module, calls to action_ship_end(), sale's function.

If picking was canceled. In action_ship_end(), it always writes shipped=True except that it finds in the sale, pickings in state different to 'done' or 'cancel',  then when you cancel an out picking the sale order will be shipped and it isn't right.

I include a patch that changes this check, it searches for pickings in the sale with state different to 'done' or 'cancel' for calls to action_ship_end() if it only finds picking in done or cancel  states it doesn't call to function. Reversing the current behavior.