c2c-oerpscenario team mailing list archive

["Jay \(OpenERP\)" <jvo@xxxxxxxxxxx>]

Thanks for the study Omar.

Long story short, 'Shipped' should not be made true when you cancel the
picking.

I used these cases:
1. SO has One picking, you cancel it, SHIPPED is not true now. Earlier it was getting true.
2. SO has one picking, I did partial picking. So there are 2 pickings on SO now. One is available, one is done. I cancel the available one. So the code was earlier setting shipped=True, and now too it can set shipped =True (with my patch). I guess that with your patch,the flag will be set False and ship will not be ticked. You say that it should not be set shipped?

Thanks again.

-- 
[5.0][sale] Cancelling an out picking sets the sale order as shipped
https://bugs.launchpad.net/bugs/646224
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: In Progress

Bug description:
Hi,

If I cancel an out picking, it always writes in sale order "shipped=True", because action_cancel() from stock.picking extended in sale module, calls to action_ship_end(), sale's function.

If picking was canceled. In action_ship_end(), it always writes shipped=True except that it finds in the sale, pickings in state different to 'done' or 'cancel',  then when you cancel an out picking the sale order will be shipped and it isn't right.

I include a patch that changes this check, it searches for pickings in the sale with state different to 'done' or 'cancel' for calls to action_ship_end() if it only finds picking in done or cancel  states it doesn't call to function. Reversing the current behavior.