c2c-oerpscenario team mailing list archive

Thread
Date

[Bug 649029] Re: [sale] incoterm field poorly implemented [direct sql / not translatable]

To: c2c-oerpscenario@xxxxxxxxxxxxxxxxxxx
From: "Cristian Salamea \(GnuThink\)" <ovnicraft@xxxxxxxxx>
Date: Fri, 05 Nov 2010 00:53:58 -0000
Reply-to: Bug 649029 <649029@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

@Omar can you propose to merge your patch?

-- 
[sale] incoterm field poorly implemented [direct sql / not translatable]
https://bugs.launchpad.net/bugs/649029
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: New

Bug description:
Hi,

Checking incoterm field in sales, I see that, it is a selection field with a get function, it should be a many2one field, directly to stock_incoterms, then in the view, if it wants, you write widget="selection".

Current implementation isn't good, because in the get function it uses a sql query. In addition, if you want work with this field it returns by default the code of incoterm (code isn't unique) instead of his Id.

I include my diff file. If my file is applied, you should delete the get function and incoterm line commented.