← Back to team overview

c2c-oerpscenario team mailing list archive

Re: [Bug 327259] Re: "Children" not "childs"

 

On Monday 08 November 2010, you wrote:
> same for "datas" instead of "data"

IMHO, spell-checking the code makes no sense. Variable names are arbitrary, 
they needn't follow any language rules [1].
So, "datas" is correct, "dataass" is also correct. I know even more names[2] 
that would be lousy English. So what?

On the other hand, renaming variables just for the sake of English 
correctness, may introduce real bugs in modules that reference those names. 
What if the "datas" column is not properly migrated to the "data" one?

Surely, when a _new_ module or piece of code is introduced, we'd better try to 
have sensible names for the _new_ variables. 

[1] except that they must not be confusing and fit in a single 15'' monitor, no 
Java ones, please!
[2] yes, including the "ressource" one

-- 
"Children" not "childs"
https://bugs.launchpad.net/bugs/327259
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: Confirmed
Status in OpenObject Web Client: Confirmed
Status in OpenObject Server: Confirmed

Bug description:
English is not my mother tongue, so forgive me if I'm wrong, but : very often on OpenERP we see "childs" written instead of "children" and that's wrong.
You can find it in the code, in field names, in help texts, and in draft books.

One problem with that is that our English/American users surely won't find it professional looking. Another problem is that it makes searching the code a little bit harder.

I know it may seem strange to refactor  only to fix typos but from I think it's worth it in the long term.





References