← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 673087] Re: Spelling errors in the code

 

Marking it "Opinion" rather than "Won't Fix" is okay for me as it clears
it from the list of currently outstanding bugs for v6 (and your tag
suggestion is a good idea too). Not sure if "Opinion" bugs can be
reopened though? It's also a bit of a misnomer in this case, but at
least we can explain it in the comments.

** Changed in: openobject-addons
       Status: Won't Fix => Opinion

-- 
Spelling errors in the code
https://bugs.launchpad.net/bugs/673087
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: Opinion

Bug description:
There are lots of small spelling mistakes throughout the code : datas=data, childs=children, logistic=logistics etc.
I think these deserve to be fixed one day.

The point of correct English in the code is:
- well-written code is a documentation in itself
- you can't search for misspelled words in IDEs
- bad English is a clue to find code that was never reviewed nor refactored
- respect for your fellow developers worldwide

It's not risky because:
- renaming variables and functions is easily and quickly done (ecplise even has a wizard for it)
- bzr lets you review what you merge
- yml tests will catch the problems
Lionel

Related bugs : Bug #326160, Bug #327259 





References