c2c-oerpscenario team mailing list archive

["Albert Cervera i Areny - http://www.NaN-tic.com" <albert@xxxxxxxxxxx>]

** Branch linked: lp:~openerp-community-committers/openobject-
addons/5.0-bugfix-599090

-- 
account.move.line check is too strict
https://bugs.launchpad.net/bugs/599090
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: Triaged

Bug description:
account.move.line checks some fields are not updated if the line is reconciled or the move is not in draft state. There is a problem, though, that forbids users from removing unreconciled entries of a draft account moves.

When the user wants to remove a couple of lines of a draft move (leaving the move still in valid state), the system will call account.move validate() function. This function calls account.move.line write() for all account move lines of the move, forbiding the removal if there are move lines in reconciled state. The problem is that account.move's validate() function is not necessarily changing any of the forbiden values, it simply ensures they're properly set. As account.move.line's write() function doesn't check if those values are really changing it always raises an exception.

The attached patch fixes this problem by checking if any of the fields that must not be changed are really changing and only calls _update_check() function if necessary. This results in the described scenario to be usable again and thus letting users modify unreconciled move lines as expected.