c2c-oerpscenario team mailing list archive

[OpenERP buildbot <673963@xxxxxxxxxxxxxxxxxx>]

On Thursday 11 November 2010, you wrote:
 
>...
> 12:13:28,699][v6testcrm] ERROR:FTP:[07]:     assert '..' not in p_parts
> I think the ".." handling is OS specific and not part of the FTP spec. But
> I think it is considered as normal behavior by most client.

If you look at the code, this has intentionally be left out. The algorithm 
(including the node reduction loop, for speed) has not been patched yet to 
handle a stray ".." as a cd or reference (as in "ls ..").
The assert is there to prevent any ugly behaviour of the current algorithm. It 
is certainly in our todo list[2] to patch it so that ".." works as 
expected[1]. It is part of the standard, for sure, not some OS specific trick.

Conclusion: yes, we will fix this!

[1] keeping in mind that GUI clients or ftp-mounted dirs don't use it so much.
[2] have you realized how long that list is, btw?

-- 
Say NO to spam and viruses. Stop using Microsoft Windows!

-- 
TRUNK cd .. ERROR 451 in FTP Client
https://bugs.launchpad.net/bugs/673963
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: Invalid

Bug description:
Installed CRM , with document management and demo data.

FTP to the server login admin

tp> pwd
257 "/v6testcrm/principals/__uids__/admin" is the current directory.
ftp> cd ..
451 Exception.
ftp> 

[2010-11-11 12:10:11,550][v6testcrm] INFO:FTP:[admin]@127.0.0.1:47461 FAIL get_crdata()  ".." Exception:  Exception.
[2010-11-11 12:13:28,698][v6testcrm] ERROR:FTP:[01]: Traceback (most recent call last):
[2010-11-11 12:13:28,698][v6testcrm] ERROR:FTP:[02]:   File "/home/chanon/OPENERP/openerp-TRUNK/server/bin/addons/document_ftp/ftpserver/ftpserver.py", line 1800, in try_as_current_user
[2010-11-11 12:13:28,699][v6testcrm] ERROR:FTP:[03]:     return self.run_as_current_user(function, *args, **kwargs)
[2010-11-11 12:13:28,699][v6testcrm] ERROR:FTP:[04]:   File "/home/chanon/OPENERP/openerp-TRUNK/server/bin/addons/document_ftp/ftpserver/ftpserver.py", line 1775, in run_as_current_user
[2010-11-11 12:13:28,699][v6testcrm] ERROR:FTP:[05]:     return function(*args, **kwargs)
[2010-11-11 12:13:28,699][v6testcrm] ERROR:FTP:[06]:   File "/home/chanon/OPENERP/openerp-TRUNK/server/bin/addons/document_ftp/ftpserver/abstracted_fs.py", line 274, in get_crdata
[2010-11-11 12:13:28,699][v6testcrm] ERROR:FTP:[07]:     assert '..' not in p_parts
[2010-11-11 12:13:28,700][v6testcrm] ERROR:FTP:[08]: AssertionError
[2010-11-11 12:13:28,700][v6testcrm] INFO:FTP:[admin]@127.0.0.1:47461 FAIL get_crdata()  ".." Exception:  Exception.


I think the ".." handling is OS specific and not part of the FTP spec. But I think it is considered as normal behavior by most client.