c2c-oerpscenario team mailing list archive

["Jay \(OpenERP\)" <jvo@xxxxxxxxxxx>]

** Also affects: openobject-server/5.0
   Importance: Undecided
       Status: New

** Also affects: openobject-server/trunk
   Importance: Undecided
       Status: Confirmed

** Changed in: openobject-server/trunk
       Status: Confirmed => Invalid

** Changed in: openobject-server/5.0
       Status: New => Won't Fix

-- 
Update using repository does not work
https://bugs.launchpad.net/bugs/367825
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Server: Invalid
Status in OpenObject Server 5.0 series: Won't Fix
Status in OpenObject Server trunk series: Invalid

Bug description:
v5.0.0-3

The update of modules based on repositories can't work with current code.
Moreover, the repository packages are supposed to be <name of the module>-<version of the module><extension>
which is NOT the case in OpenERP own URLs

Proposed patch
--- bin/addons/base/module/module.py	(revision 6806)
+++ bin/addons/base/module/module.py	(working copy)
@@ -398,7 +398,7 @@
             if not download:
                 continue
             zipfile = urllib.urlopen(mod.url).read()
-            fname = addons.get_module_path(mod.name+'.zip')
+            fname = addons.get_module_path_for_creation(mod.name+'.zip')
             try:
                 fp = file(fname, 'wb')
                 fp.write(zipfile)
===================================================================
--- bin/addons/__init__.py	(revision 6806)
+++ bin/addons/__init__.py	(working copy)
@@ -139,6 +139,9 @@
         return s
 
 
+def get_module_path_for_creation(module):
+    return opj(_ad,module)
+
 def get_module_path(module):
     """Return the path of the given module."""