← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 672669] Re: [6.0rc1] Poor error handling on import of many2many

 

I attach a module that demonstrates the (remaining) problem on a basic
demo database. It appears that between reporting this bug and RC1, which
I am now running, issue 2 was fixed. That is, it now tells me which
relation is at fault.

However, all previous data is still rolled back. In this data you will see there are three users. Only the third has an error in the data ('Partner / Manager' instead of 'Partner Manager') but none of the users are committed. If there were previous data files in the module they too would be rolled back. If there were following files in the module they would be loaded and (assuming no more errors) committed.
Either this should be a fatal error and loading should stop, or it should give a warning and only this record is not committed. The warning should identify the record, as well as the broken field, and all other data should be committed.

Incidentally, Product Manager used to have a slash but Fabien removed it
for some reason.

** Attachment added: "m2m_load_demo.zip"
   https://bugs.launchpad.net/openobject-server/+bug/672669/+attachment/1754252/+files/m2m_load_demo.zip

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/672669

Title:
  [6.0rc1] Poor error handling on import of many2many

Status in OpenObject Server:
  Incomplete

Bug description:
  I have a CSV file of user data res.users.csv in my module. Some of my users belong to several groups. Upon installing my module I was getting a warning in the log:

WARNING:import:Relation not found: Accounting / Accountant,Accounting / Invoice,Accounting / Manager,Administration / Acc
ess Rights,Administration / Configuration,Citrus Growers Association,Internal User,Inventory,Inventory / Checker,Inventory / Coldstore Supervisor,Inventory 
/ Forklift Operator,Partner Manager,Pounds Solids / Manager,Pounds Solids / Tech,Product / Manager,Receiving,Receiving / Data Entry Clerk,Receiving / Logist
ics Coordinator,Receiving / Maturity Lab Tech,Receiving / Receiving Foreman,Receiving / Scale Operator,Receiving / Security Officer,Receiving / Sipesa,Recei
ving / Yard Marshall,Sales / Manager,Sales / User,Useability / Analytic Accounting,Useability / Extended View,Useability / Multi Companies,Useability / No O
ne,Useability / Product UoS View,Useability / Product Variant,Warehouse / Manager,Warehouse / User on 'res.groups'

I have three issues with this:

1) All data loaded before this point is rolled back but the install continues. Either roll-back and stop, or commit and go forward. Don't leave me half-installed with nothing but a warning in the log.

2) Which of these twenty-eight items is the problem? Each one is checked individually so tell me exactly which one breaks.

3) After going through in the debugger I discovered it was Product / Manager. This is one of your groups. What was wrong with it? It should not have a slash. You have Sales / Manager, Accounting / Manager, Warehouse / Manager - but you also have Partner Manager and Product Manager. Consistency please!





References