← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 672669] Re: [6.0rc1] Poor error handling on import of many2many

 

After adding my last comment I realised I reported this bug against RC1, and I am still running RC1. So how was issue 2 fixed?
I did it myself. Doh!
Heres a diff:

=== modified file 'bin/osv/orm.py'
--- bin/osv/orm.py	2010-10-18 16:16:38 +0000
+++ bin/osv/orm.py	2010-11-29 16:55:11 +0000
@@ -888,10 +888,10 @@
                                         uid, word, [], operator='=', context=context)
                                 res3 = (res2 and res2[0][0]) or False
                                 if not res3:
-                                    warning += [_("Relation not found: %s on '%s'") % (line[i], relation)]
+                                    warning += [_("Relation not found: %s on '%s'") % (word, relation)]
                                     logger.notifyChannel("import",
                                             netsvc.LOG_WARNING,
-                                            _("Relation not found: %s on '%s'") % (line[i], relation))
+                                            _("Relation not found: %s on '%s'") % (word, relation))
                                 else:
                                     res.append(res3)
                             if len(res):

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/672669

Title:
  [6.0rc1] Poor error handling on import of many2many

Status in OpenObject Server:
  Incomplete

Bug description:
  I have a CSV file of user data res.users.csv in my module. Some of my users belong to several groups. Upon installing my module I was getting a warning in the log:

WARNING:import:Relation not found: Accounting / Accountant,Accounting / Invoice,Accounting / Manager,Administration / Acc
ess Rights,Administration / Configuration,Citrus Growers Association,Internal User,Inventory,Inventory / Checker,Inventory / Coldstore Supervisor,Inventory 
/ Forklift Operator,Partner Manager,Pounds Solids / Manager,Pounds Solids / Tech,Product / Manager,Receiving,Receiving / Data Entry Clerk,Receiving / Logist
ics Coordinator,Receiving / Maturity Lab Tech,Receiving / Receiving Foreman,Receiving / Scale Operator,Receiving / Security Officer,Receiving / Sipesa,Recei
ving / Yard Marshall,Sales / Manager,Sales / User,Useability / Analytic Accounting,Useability / Extended View,Useability / Multi Companies,Useability / No O
ne,Useability / Product UoS View,Useability / Product Variant,Warehouse / Manager,Warehouse / User on 'res.groups'

I have three issues with this:

1) All data loaded before this point is rolled back but the install continues. Either roll-back and stop, or commit and go forward. Don't leave me half-installed with nothing but a warning in the log.

2) Which of these twenty-eight items is the problem? Each one is checked individually so tell me exactly which one breaks.

3) After going through in the debugger I discovered it was Product / Manager. This is one of your groups. What was wrong with it? It should not have a slash. You have Sales / Manager, Accounting / Manager, Warehouse / Manager - but you also have Partner Manager and Product Manager. Consistency please!





References