← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 685328] Re: Module import: no check on file technical format

 

I reduce that to "opinion" and would prefer to see it becoming "invalid".
If you do have an error message for an invalid file (an exception message), that's sufficient. Writting code to accomodate any exotic file format that anybody would drop into OpenERP addons[1] is a luxury.

[1] and we're talking about administrator actions, not files placed by
ignorant users.

** Changed in: openobject-server
       Status: New => Opinion

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/685328

Title:
  Module import: no check on file technical format

Status in OpenObject Server:
  Opinion

Bug description:
  Note this bug is potentially applicable to V6...

On my Windows 7 system, I created an Excel macro that generates an OpenERP module with all the required files (init, terp, and all csv containing datas).

When trying to import the zip folder via the administration menu, the system was importing the module in the module list but the module description form was empty or containing partial data in regards to the TERP file content.

Furthermore, after the import of the module into the module list the system was so corrupted (impossible to create new DB anymore) that I had to reinstall OpenERP from scratch.

After check with OpenERP support, it appeared that it was due to the file technical format generated by Windows and the Excel Macro while OpenERP current requirements are:
- UTF8 (without BOM) for CSV upload files but with windows format supported
- UTF8 (without BOM) for TERP and INIT files but accepting only UNIX format

When you know that, it's OK, you know you have to convert your files format. 

Nevertheless, I think it's a security issue because if someone imports a module with unsupported format it corrupts the system and you see only it when you want to create a new DB !!! 

I think a check with an error message/popup should be implemented in order to be sure of the file technical formats when importing a module.





References