c2c-oerpscenario team mailing list archive

["Jordi Esteve \(www.zikzakmedia.com\)" <jesteve@xxxxxxxxxxxxxxx>]

Corentin, in revision 4648 you have included some changes in smtpclient
module that I don't understand and I think they don't have any relation
with this bug and patch. Maybe you have committed them by error, could
you check and revert them?


------------------------------------------------------------
revno: 4648
committer: Corentin POUHET-BRUNERIE <corentin.pouhet-brunerie@xxxxxxxx>
branch nick: extra-addons
timestamp: Tue 2010-11-23 11:41:18 +0100
message:
  [FIX] Bug 677867
  [FIX] Trigger on function field and trigger on unlink

=== modified file 'smtpclient/smtpclient.py'
--- smtpclient/smtpclient.py    2010-05-29 12:24:33 +0000
+++ smtpclient/smtpclient.py    2010-11-23 10:41:18 +0000
@@ -97,21 +97,21 @@
 #        result = override_password(result)
 #        return result

-    def write(self, cr, user, ids, vals, context=None):
-        flag = False
-        if vals.get('password', False) != False:
-            for pass_char in vals.get('password'):
-                if pass_char != '*':
-                    flag= True
-                    break
-
-            if flag:
-                vals['password'] = base64.b64encode(vals.get('password'))
-            else:
-                del vals['password']
-
-        res = super(SmtpClient, self).write(cr, user, ids, vals, context)
-        return res
+#    def write(self, cr, user, ids, vals, context=None):
+#        flag = False
+#        if vals.get('password', False) != False:
+#            for pass_char in vals.get('password'):
+#                if pass_char != '*':
+#                    flag= True
+#                    break
+#
+#            if flag:
+#                vals['password'] = base64.b64encode(vals.get('password'))
+#            else:
+#                del vals['password']
+#
+#        res = super(SmtpClient, self).write(cr, user, ids, vals, context)
+#        return res

     def change_email(self, cr, uid, ids, email):
         ptrn = re.compile('(\w+@\w+(?:\.\w+)+)')
@@ -445,7 +445,21 @@
         'history':fields.char('History',size=64, readonly=True),
         'no':fields.integer('Total No.',readonly=True),
     }
-    def init(self, cr):
+    def init(self, cr):#    def write(self, cr, user, ids, vals, context=None):
+#        flag = False
+#        if vals.get('password', False) != False:
+#            for pass_char in vals.get('password'):
+#                if pass_char != '*':
+#                    flag= True
+#                    break
+#
+#            if flag:
+#                vals['password'] = base64.b64encode(vals.get('password'))
+#            else:
+#                del vals['password']
+#
+#        res = super(SmtpClient, self).write(cr, user, ids, vals, context)
+#        return res

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/677867

Title:
  [extra-5.0 smile-action-trigger] incompatible with python 2.5

Status in OpenObject Addons Modules:
  Won't Fix

Bug description:
  Hi,

by presupposing that inspect.getargspec returns a named tuple like it does in Python 2.6, the excellent smile-action-trigger module does not install properly anymore when using Python 2.5. The installation process dies with the message

    'tuple' object has no attribute 'args'

It would be nice to retain compatibility with Python 2.5 for the OpenERP 5-version of this module. This should be easy to accomplish by changing the way in which the tuple item is referred to from '.args' to [0].

Applies to stable_5.0-extra-addons, revision 4644.

Cheers,
Stefan.