← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 539722] Re: Close button remembers changes

 

Hello jean-Luc-WEYL,

 Your comment #4 is valid and was a bug. which has been improved @ lp:~openerp-dev/openobject-client/trunk-dev-client
 with revision info as 1415 nch@xxxxxxxxxxx-20101228121607-hid96njqyhof8irk and will be merged soon to the trunk client.

 Now for the comment #5 which seems a whishlist rather then a bug because according to the current architecture of O2M
 or any other type:

case 1: If the model is not saved i.e does not have any ID yet :
            when you focus out of any field that field will fire an 'focus-out' event which in turn will store that field value in the internal client's model and will be used for the further operations. So when you press cancel as the model does not have ID will just return silently. here we may think to revert back to the old value but the question is from where would we get the old value as the models internal data has already changed.

case 2: If the model is  saved i.e does  have an ID:
            when you focus out of any field that field will fire an 'focus-out' event which in turn will store that field value in the internal client's model and will be used for the further operations.So when you press cancel as the model does  have an ID here will make an read request to the server with the ID to get the latest stored values.

may be we should consider this for the future version improvements (i.e
v6.1) or so .

Hope you understand.

Thanks,

** Changed in: openobject-client/trunk
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/539722

Title:
  Close button remembers changes

Status in OpenObject GTK Client:
  Fix Released
Status in OpenObject GTK Client trunk series:
  Fix Released

Bug description:
  When you use the close button to close a separate window (sale.order.line and similar) it remembers changed data, if that object already existed.

Example:
Create a new sale order and add one sale order line, press ok to add this new sale order line to the sale order.
Now edit that same entry and make the description (or any other required field) empty, and press the close button.

If you now edit that same line the description will still be empty. So it won't validate unless you fill it in again.

Running the client with log-level=debug_rpc_answer shows that pressing the close button doesn't trigger any event.

The behavior I think I should be seeing is that it asks me if I want to save my changes. At least that's what I see in the handling of the close signal in the client code.

Using OpenERP 5.0.7 (both server and client).