← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 575616] Re: spinbutton scroll changes prices and quantities

 

Hello Frédéric,

Thank you for the proposed patch, however it looks like this would
disable the mousewheel as well as the up/down buttons on all
integer/float fields, which could be quite annoying and make them harder
to use.

I suppose it makes sense to use a locally patched client if your users tend to use the mousewheel when focused on int/float fields.
Maybe for the future we could think of a way to selectively turn this feature on/off. Alternatively you could consider switching the sensitive fields to a different widget, if you only have a few.

I hope you understand our point of view...

** Changed in: openobject-client
       Status: New => Opinion

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/575616

Title:
  spinbutton scroll changes prices and quantities

Status in OpenObject GTK Client:
  Opinion

Bug description:
  Scrolling on GTK/QT spinbuttons changes value. But it's too much
  dangerous to change prices and quantities on the fly. Even if we
  confirm changes on popup, we may not have seen all changes we confirm.

  As far as I know, we can't disable scrolling on spinbuttons, but we
  can set step increment to 0 instead of one.

  I propose to change those lines:
  ./widget/view/form_gtk/spinbutton.py:        adj = gtk.Adjustment(0.0, -sys.maxint, sys.maxint, 1.0, 5.0)
  ./widget/view/form_gtk/spinint.py:              adj = gtk.Adjustment(0.0, -sys.maxint, sys.maxint, 1.0, 5.0)
  into:
  ./widget/view/form_gtk/spinbutton.py:        adj = gtk.Adjustment(0.0, -sys.maxint, sys.maxint, 0.0, 5.0)
  ./widget/view/form_gtk/spinint.py:              adj = gtk.Adjustment(0.0, -sys.maxint, sys.maxint, 0.0, 5.0)

  Thanks for applying changes or returning a feed-back.