c2c-oerpscenario team mailing list archive

["Dhruti Shastri\(OpenERP\)" <646224@xxxxxxxxxxxxxxxxxx>]

Hello Omar,

Will you please check with the latest patch and let us know if anything
is wrong with the patch?

Thanks.

** Patch added: "sale_picking_cancelled.patch"
   https://bugs.launchpad.net/openobject-addons/+bug/646224/+attachment/1838154/+files/sale_picking_cancelled.patch

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/646224

Title:
  [5.0][sale] Cancelling an out picking sets the sale order as shipped

Status in OpenERP Modules (addons):
  In Progress

Bug description:
  Hi,

  If I cancel an out picking, it always writes in sale order
  "shipped=True", because action_cancel() from stock.picking extended in
  sale module, calls to action_ship_end(), sale's function.

  If picking was canceled. In action_ship_end(), it always writes
  shipped=True except that it finds in the sale, pickings in state
  different to 'done' or 'cancel',  then when you cancel an out picking
  the sale order will be shipped and it isn't right.

  I include a patch that changes this check, it searches for pickings in
  the sale with state different to 'done' or 'cancel' for calls to
  action_ship_end() if it only finds picking in done or cancel  states
  it doesn't call to function. Reversing the current behavior.